----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72122/#review219916 -----------------------------------------------------------
Fix it, then Ship it! src/linux/cgroups.cpp Line 665 (original), 677 (patched) <https://reviews.apache.org/r/72122/#comment308155> Do we need `path::join("/", ` like the previous code? - Qian Zhang On Feb. 12, 2020, 11:48 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72122/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2020, 11:48 p.m.) > > > Review request for mesos, Greg Mann and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > This patch modifies `cgroups::create` function to call > `cloneCpusetCpusMems` for all absent nested cgroups along > the path to a cgroup that is accepted as an argument of this function. > For instance, if `cgroups::create` is called to create three > non-existent cgroups recursively for the path `/a/b/c`, then > `cloneCpusetCpusMems` is called to clone both `cpuset.cpus` and > `cpuset.mems` for `/a` from its parent, then `/a/b` from `/a`, > and so on down the path. > > > Diffs > ----- > > src/linux/cgroups.cpp 73646c9eb39948192acedb67e3d2fb13acb14b30 > > > Diff: https://reviews.apache.org/r/72122/diff/3/ > > > Testing > ------- > > > Thanks, > > Andrei Budnik > >
