----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72233/#review219934 -----------------------------------------------------------
Ship it! Ship It! - Andrei Sekretenko On March 12, 2020, 10 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72233/ > ----------------------------------------------------------- > > (Updated March 12, 2020, 10 p.m.) > > > Review request for mesos and Andrei Sekretenko. > > > Bugs: MESOS-10103 > https://issues.apache.org/jira/browse/MESOS-10103 > > > Repository: mesos > > > Description > ------- > > Found by Andrei Sekretenko using -fsanitize=address, the following > expression has an intermediate temporary! > > const RepeatedPtrField<Resource::ReservationInfo>& > ancestorReservations = > RepeatedPtrField<Resource>(ancestor).begin()->reservations(); > > Therefore, the intermediate temporary will not have its lifetime > extended and this is undefined behavior which leads to a crash > in the windows CI. > > > Diffs > ----- > > src/master/authorization.cpp 6dfa59ad621d9aa0fd1dbbdbe4fa8965e413774f > > > Diff: https://reviews.apache.org/r/72233/diff/1/ > > > Testing > ------- > > Ran through windows CI. > > > Thanks, > > Benjamin Mahler > >
