----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72221/#review220001 -----------------------------------------------------------
src/slave/validation.cpp Line 285 (original), 298-299 (patched) <https://reviews.apache.org/r/72221/#comment308260> A newline between. src/slave/validation.cpp Line 386 (original), 408 (patched) <https://reviews.apache.org/r/72221/#comment308257> Kill this line. src/slave/validation.cpp Lines 460-464 (patched) <https://reviews.apache.org/r/72221/#comment308267> Why do we need `Option` here? Since `share_cgroups` is true by default, I think we could change this block to: ``` bool shareCgroups = (launch.container().has_linux_info() && launch.container().linux_info().has_share_cgroups()) ? launch.container().linux_info().share_cgroups() : true; ``` src/slave/validation.cpp Lines 466-474 (patched) <https://reviews.apache.org/r/72221/#comment308268> I see you have already done this validation in L492:L497, so I think we could remove this. src/slave/validation.cpp Lines 476-504 (patched) <https://reviews.apache.org/r/72221/#comment308269> I think these validations should be done outside of the `if (launch.has_container()) {` at L453, because we want to do them even there is no `ContainerInfo` specified. - Qian Zhang On March 19, 2020, 10:11 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72221/ > ----------------------------------------------------------- > > (Updated March 19, 2020, 10:11 a.m.) > > > Review request for mesos, Andrei Budnik and Qian Zhang. > > > Bugs: MESOS-10045 > https://issues.apache.org/jira/browse/MESOS-10045 > > > Repository: mesos > > > Description > ------- > > Added agent validation for shared cgroups. > > > Diffs > ----- > > src/slave/validation.cpp 99b17c965d4cc522e9106078a9e6f34fae396b8a > > > Diff: https://reviews.apache.org/r/72221/diff/3/ > > > Testing > ------- > > > Thanks, > > Greg Mann > >
