----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72222/#review220031 -----------------------------------------------------------
Fix it, then Ship it! src/tests/slave_validation_tests.cpp Lines 531 (patched) <https://reviews.apache.org/r/72222/#comment308295> Could you please also check the containers nested at the second level or greater? - Qian Zhang On March 19, 2020, 10:12 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72222/ > ----------------------------------------------------------- > > (Updated March 19, 2020, 10:12 a.m.) > > > Review request for mesos, Andrei Budnik and Qian Zhang. > > > Bugs: MESOS-10045 > https://issues.apache.org/jira/browse/MESOS-10045 > > > Repository: mesos > > > Description > ------- > > This patch adds validation for shared cgroups when specified > via the agent APIs. In doing so, a new validation test is > added for the agent's LaunchContainer API, since this was > previously missing. > > > Diffs > ----- > > src/tests/slave_validation_tests.cpp > 25019ccdc34db35770b0f69301b94e38636059b7 > > > Diff: https://reviews.apache.org/r/72222/diff/3/ > > > Testing > ------- > > `make check` > > > Thanks, > > Greg Mann > >
