bmahler commented on a change in pull request #353: hook manager mutex and
global variable enhancement
URL: https://github.com/apache/mesos/pull/353#discussion_r397425354
##########
File path: src/hook/manager.cpp
##########
@@ -47,16 +47,16 @@ using mesos::modules::ModuleManager;
namespace mesos {
namespace internal {
-static std::mutex mutex;
-static LinkedHashMap<string, Hook*> availableHooks;
+static std::mutex* mutex = new(std::mutex);
+static LinkedHashMap<string, Hook*>* availableHooks =
new(LinkedHashMap<string, Hook*>);
Review comment:
I'm not familiar with this `new` syntax, we would use:
```
static std::mutex* mutex = new std::mutex();
static LinkedHashMap<string, Hook*>* availableHooks = new
LinkedHashMap<string, Hook*>();
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
