----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72269/#review220132 -----------------------------------------------------------
src/webui/app/agents/agent-executor.html Lines 155-158 (patched) <https://reviews.apache.org/r/72269/#comment308456> Maybe we should change `Request` to `Allocated` to be consistent with `GPUs (allocated)` and `Disk (allocated)`? For a running task, its resources are indeed allocated (i.e. enforaced in cgroups). src/webui/app/agents/agent-executor.html Lines 178-179 (original), 194-195 (patched) <https://reviews.apache.org/r/72269/#comment308457> Not yours, but I think for a completed task, its resources should already be freed rather than still allocated, so maybe we should remove `(allocated)` here? - Qian Zhang On March 31, 2020, 3:23 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72269/ > ----------------------------------------------------------- > > (Updated March 31, 2020, 3:23 a.m.) > > > Review request for mesos and Qian Zhang. > > > Bugs: MESOS-10055 > https://issues.apache.org/jira/browse/MESOS-10055 > > > Repository: mesos > > > Description > ------- > > Added resource limits to the web UI. > > > Diffs > ----- > > src/webui/app/agents/agent-executor.html > 7ec56c3bd039ee190c0f1c61ec8957001b52f1dc > > > Diff: https://reviews.apache.org/r/72269/diff/2/ > > > Testing > ------- > > Viewed manually in a web browser. > > > File Attachments > ---------------- > > UI Before Change > > https://reviews.apache.org/media/uploaded/files/2020/03/30/60bdc793-bd03-467a-8504-f2686a9b176f__before.png > UI After Change > > https://reviews.apache.org/media/uploaded/files/2020/03/30/f171975f-0abf-4766-ad8e-42516261f1ec__after.png > > > Thanks, > > Greg Mann > >
