bmahler commented on issue #356: libprocess: check protobuf (de)serialisation success. URL: https://github.com/apache/mesos/pull/356#issuecomment-610660551 > On a slightly-tangential subject: how do you deal with formatting? I can see that there's a support/clang-format file, but applying it with e.g. clang-format version 7 results in many changes - I guess the code base hasn't been re-formatted to avoid churn? I personally don't use clang-format but some others in the project do. At this point as long as your commit can pass the pre-commit hooks it's ok, but reviewers might have differing formatting preferences as we don't have a single way: http://mesos.apache.org/documentation/latest/c++-style-guide/
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
