----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72355/#review220288 -----------------------------------------------------------
Patch looks great! Reviews applied: [72354, 72355] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewbot On April 11, 2020, 5:25 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72355/ > ----------------------------------------------------------- > > (Updated April 11, 2020, 5:25 a.m.) > > > Review request for mesos, Andrei Sekretenko and Benjamin Mahler. > > > Bugs: MESOS-10111 > https://issues.apache.org/jira/browse/MESOS-10111 > > > Repository: mesos > > > Description > ------- > > This patch updates the socket interface to permit the > addition of a test for the fix to MESOS-10111. The new test > fails before the fix is applied, and passes after. > > This code is not intended to be merged as-is. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/socket.hpp > cf594cf34b40578616753493a900ff5e2674cde2 > 3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.hpp > 7bcc66fb3501d6c120bc13d2fd85bd98dbb5673a > 3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp > dcb6d8e6c82005145c853afa9c24a61d7d0f04a9 > 3rdparty/libprocess/src/tests/ssl_tests.cpp > 3f1d1039bfdd686e43395c55c8edf6ab863ca7ac > > > Diff: https://reviews.apache.org/r/72355/diff/1/ > > > Testing > ------- > > `3rdparty/libprocess/libprocess-tests --gtest_filter="*Libevent*"` > > > Thanks, > > Greg Mann > >
