----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72354/#review220299 -----------------------------------------------------------
Ship it! Perhaps describing an example of such a race in the description would be helpful for posterity? Ideally the one we encountered in practice with the check failure? - Benjamin Mahler On April 11, 2020, 5:21 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72354/ > ----------------------------------------------------------- > > (Updated April 11, 2020, 5:21 a.m.) > > > Review request for mesos, Andrei Sekretenko and Benjamin Mahler. > > > Bugs: MESOS-10111 > https://issues.apache.org/jira/browse/MESOS-10111 > > > Repository: mesos > > > Description > ------- > > This fixes an issue where the functions `shutdown()` and > `event_callback()` race to access the bufferevent held by > our libevent SSL socket implementation, leading to a > CHECK failure. > > > Diffs > ----- > > 3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp > dcb6d8e6c82005145c853afa9c24a61d7d0f04a9 > > > Diff: https://reviews.apache.org/r/72354/diff/1/ > > > Testing > ------- > > This fix is tested in https://reviews.apache.org/r/72355/, though it's likely > the test code will not be merged since it involves unsightly modifications to > the socket interface. > > > Thanks, > > Greg Mann > >
