----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72348/#review220312 -----------------------------------------------------------
3rdparty/libprocess/include/process/address.hpp Lines 344-367 (original), 344-371 (patched) <https://reviews.apache.org/r/72348/#comment308651> Since `sockaddr_storage` can be cast as `sockaddr_{un,in,in6}`, maybe we want to combine these into a single function? Actually, after looking at some existing callsites of `Address::create()`, I wonder if we should eliminate the overload for `sockaddr_storage`? 3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp Line 1137 (original), 1133 (patched) <https://reviews.apache.org/r/72348/#comment308650> Should we include the address in this failure message as well? Maybe it's not as relevant here? - Greg Mann On April 10, 2020, 7:30 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72348/ > ----------------------------------------------------------- > > (Updated April 10, 2020, 7:30 p.m.) > > > Review request for mesos and Greg Mann. > > > Bugs: MESOS-10112 > https://issues.apache.org/jira/browse/MESOS-10112 > > > Repository: mesos > > > Description > ------- > > The caller of LibeventSSLSocket::accept() cannot see who tried to > connect when accept fails, since the accepted socket is not returned. > This adds logging of the peer address when the SSL handshake fails, > in order to improve debugging. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/address.hpp > f23e653aa276e4806a88d8b54f84375ccbaad006 > 3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.hpp > 7bcc66fb3501d6c120bc13d2fd85bd98dbb5673a > 3rdparty/libprocess/src/posix/libevent/libevent_ssl_socket.cpp > dcb6d8e6c82005145c853afa9c24a61d7d0f04a9 > > > Diff: https://reviews.apache.org/r/72348/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
