----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72405/#review220438 -----------------------------------------------------------
Ship it! Ship It! - Greg Mann On April 21, 2020, 5:43 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72405/ > ----------------------------------------------------------- > > (Updated April 21, 2020, 5:43 p.m.) > > > Review request for mesos, Andrei Sekretenko and Greg Mann. > > > Repository: mesos > > > Description > ------- > > This uses the zero byte read trick on Windows in order to > implement read readiness polling on Windows. > > The documentation for io::read has also been updated to explain > how zero byte reads are treated consistently across POSIX and > Windows. > > Write readiness polling is left unimplemented since it's less > straightforward. A good explanation of the Windows landscape > for polling is here: > > https://github.com/python-trio/trio/issues/52 > > A library providing an epoll like interface on Windows can > be found here: > > https://github.com/piscisaureus/wepoll > > > Diffs > ----- > > 3rdparty/libprocess/include/process/io.hpp > 468b3626e0121bc380ea592f485f3cfe9796d0fe > 3rdparty/libprocess/src/io.cpp 7288d5fa1c79f5d19a9369e6431dc98d92307868 > 3rdparty/libprocess/src/io_internal.hpp > 09bfa9a386a3eb89a987eea18e08144a50aaf5c7 > 3rdparty/libprocess/src/windows/io.cpp > 90e780d4d3eae7af71ee39ff99105147992e968d > > > Diff: https://reviews.apache.org/r/72405/diff/1/ > > > Testing > ------- > > Added a test in subsequent patch. > > > Thanks, > > Benjamin Mahler > >
