----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72442/#review220501 -----------------------------------------------------------
Patch looks great! Reviews applied: [72442] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewbot On April 27, 2020, 2:57 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72442/ > ----------------------------------------------------------- > > (Updated April 27, 2020, 2:57 p.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10049 > https://issues.apache.org/jira/browse/MESOS-10049 > > > Repository: mesos > > > Description > ------- > > When a burstable container is OOM killed because the agent host is running > out of memory, the method `MemorySubsystemProcess::oomWaited` will NOT be > invoked, it will only be invoked when the container uses more memory than > its hard memory limit (i.e., `REASON_CONTAINER_LIMITATION_MEMORY`). So we > do not need to introduce `REASON_CONTAINER_MEMORY_REQUEST_EXCEEDED`. > > > Diffs > ----- > > include/mesos/mesos.proto 9412ed736231547b22abc89188316b08d5445e78 > include/mesos/v1/mesos.proto 194c42cf57e34d803a21cab03db17614855e8692 > src/common/protobuf_utils.cpp 8d1d5c4cb0af911d8dc13e37a1adb62947513d0d > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp > 60c7a89fb809582723eb50d22f54f4c8ce697584 > > > Diff: https://reviews.apache.org/r/72442/diff/1/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
