----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72401/#review220529 -----------------------------------------------------------
Could you update the description of the patch to describe the difference between the two cases of a command task and a task with a Docker executor container? src/slave/containerizer/docker.hpp Lines 357 (patched) <https://reviews.apache.org/r/72401/#comment309012> Nit: you could use the `? :` ternary operator to initialize `generatedForCommandTask` here in the initializer list, I don't think it matters too much but it might be more readable if somebody just glances at the initializer list to see what the value is initialized to. - Greg Mann On April 22, 2020, 8:33 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72401/ > ----------------------------------------------------------- > > (Updated April 22, 2020, 8:33 a.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-8877 > https://issues.apache.org/jira/browse/MESOS-8877 > > > Repository: mesos > > > Description > ------- > > Updated Docker containerizer by not updating resources for command task. > > > Diffs > ----- > > src/slave/containerizer/docker.hpp 09fc2795289e1292134b7d4bb2cc079c80d91c3d > src/slave/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70 > src/tests/containerizer/docker_containerizer_tests.cpp > b069f518d51225c39f0cd5126c02fa08674566ab > > > Diff: https://reviews.apache.org/r/72401/diff/2/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
