> On April 29, 2020, 4:37 a.m., Greg Mann wrote: > > src/slave/containerizer/docker.cpp > > Lines 2077-2099 (patched) > > <https://reviews.apache.org/r/72402/diff/5/?file=2227711#file2227711line2077> > > > > What do you think about moving this logic into the conditionals below > > where `totalCPUs` and `totalMem` are used?
Agree! > On April 29, 2020, 4:37 a.m., Greg Mann wrote: > > src/slave/containerizer/docker.cpp > > Lines 2164-2167 (patched) > > <https://reviews.apache.org/r/72402/diff/5/?file=2227711#file2227711line2164> > > > > Should we have an `#else` case here which does not check the value of > > `cgroups_enable_cfs`? Hmm, I think we do not need that because we do not need to set CPU hard limit in usage in this case for the platforms other than Linux. > On April 29, 2020, 4:37 a.m., Greg Mann wrote: > > src/slave/containerizer/docker.cpp > > Line 2095 (original), 2179-2181 (patched) > > <https://reviews.apache.org/r/72402/diff/5/?file=2227711#file2227711line2179> > > > > Why don't we set the soft limit in this case? Because we do not enforce soft limit in this case, see https://github.com/apache/mesos/blob/master/src/docker/docker.cpp#L715:L717 . - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72402/#review220530 ----------------------------------------------------------- On April 29, 2020, 8:18 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72402/ > ----------------------------------------------------------- > > (Updated April 29, 2020, 8:18 p.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10117 > https://issues.apache.org/jira/browse/MESOS-10117 > > > Repository: mesos > > > Description > ------- > > Updated Docker containerizer's `usage()` to support resource limits. > > > Diffs > ----- > > src/slave/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70 > src/tests/containerizer/docker_containerizer_tests.cpp > b069f518d51225c39f0cd5126c02fa08674566ab > > > Diff: https://reviews.apache.org/r/72402/diff/6/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Qian Zhang > >
