----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72456/ -----------------------------------------------------------
Review request for mesos, Andrei Sekretenko and Greg Mann. Repository: mesos Description ------- This wrapper is deleted on windows and just directly calls through to execlp on POSIX. The existing callsites don't prefix the call with os:: so we can remove this wrapper for now. Also important to note is that we probably want to remove the other exec wrappers since on Windows they don't make much sense (requires emulating via a subprocess, can't directly exec like on POSIX). Diffs ----- 3rdparty/stout/include/stout/os/posix/exec.hpp db57130470e1e50baebc5e940491a47ef3dd3d98 3rdparty/stout/include/stout/os/windows/exec.hpp 89db8af637dc6634c541a39a205d16d111e76953 Diff: https://reviews.apache.org/r/72456/diff/1/ Testing ------- make check Thanks, Benjamin Mahler
