> On May 1, 2020, 4:37 p.m., Greg Mann wrote: > > Could you update the commit message to include some information about the > > particular use case that this change is relevant for - custom executor > > Docker containers?
Done. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72391/#review220576 ----------------------------------------------------------- On May 1, 2020, 9:14 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72391/ > ----------------------------------------------------------- > > (Updated May 1, 2020, 9:14 p.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10054 > https://issues.apache.org/jira/browse/MESOS-10054 > > > Repository: mesos > > > Description > ------- > > This is to ensure the resource limits of Docker container where custom > executor runs can be correctly updated when a new task is launched or > an existing task terminates. And the `resource` field in the `Container` > struct is also renamed to `resourceRequests`. > > > Diffs > ----- > > include/mesos/values.hpp 27f71d1e84f169e169e786372ed38e99be68e4ce > src/common/values.cpp 75203824a1016eae7088bee19e61ee8cf8d3a660 > src/slave/containerizer/docker.hpp 09fc2795289e1292134b7d4bb2cc079c80d91c3d > src/slave/containerizer/docker.cpp 492ac273fafb55d3e4c90d70fbf9c8c0c4fe7e70 > > > Diff: https://reviews.apache.org/r/72391/diff/4/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
