----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72364/#review220617 -----------------------------------------------------------
src/tests/master_draining_tests.cpp Lines 239 (patched) <https://reviews.apache.org/r/72364/#comment309180> Nit: s/lead to crash/lead to a crash/ src/tests/master_draining_tests.cpp Lines 256-257 (patched) <https://reviews.apache.org/r/72364/#comment309182> Nit: fits on one line. src/tests/master_draining_tests.cpp Lines 319-324 (patched) <https://reviews.apache.org/r/72364/#comment309183> Nit: it's a little weird to have one update use `TaskStatusUpdateStateEq` but not the other? And both of these expectations use `WillRepeatedly`, but I think we could do `WillOnce`. src/tests/master_draining_tests.cpp Lines 368-370 (patched) <https://reviews.apache.org/r/72364/#comment309184> I don't usually need to resume the clock to get a task running update to go through, do you know exactly what's going on here? - Greg Mann On May 4, 2020, 4:12 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72364/ > ----------------------------------------------------------- > > (Updated May 4, 2020, 4:12 p.m.) > > > Review request for mesos, Benjamin Mahler and Greg Mann. > > > Bugs: MESOS-10116 > https://issues.apache.org/jira/browse/MESOS-10116 > > > Repository: mesos > > > Description > ------- > > Added test for reactivation of a disconnected drained agent. > > > Diffs > ----- > > src/tests/master_draining_tests.cpp > f6b974f5f88f8563bd9cf6cca087b60cb5784e77 > > > Diff: https://reviews.apache.org/r/72364/diff/2/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
