----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72475/#review220658 -----------------------------------------------------------
Patch looks great! Reviews applied: [72475] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewbot On May 6, 2020, 11:34 a.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72475/ > ----------------------------------------------------------- > > (Updated May 6, 2020, 11:34 a.m.) > > > Review request for mesos, Andrei Sekretenko, Benjamin Mahler, Greg Mann, and > Qian Zhang. > > > Repository: mesos > > > Description > ------- > > Previously, if a non-checkpointed executor failed to connect to the > agent, it would silently shutdown itself without writing an error > message to the log. After we added the support for the domain sockets, > a set of potential failures during `connect` increased, so we added > this log message to help in debugging. > > > Diffs > ----- > > src/executor/executor.cpp 213f38ed9217144f32f9eeb2ef22afb054279d9b > > > Diff: https://reviews.apache.org/r/72475/diff/1/ > > > Testing > ------- > > None: not a functional change. > > > Thanks, > > Andrei Budnik > >
