----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72508/ -----------------------------------------------------------
Review request for mesos and Benjamin Mahler. Repository: mesos Description ------- Before this patch, the roles tree was tracking total resources offered/allocated to a role as a single `Resources` objects. In the case when each agent has a limited number of unique resources (for example, a single persistent voulme), this resulted in poor asymptotic complexity of allocation versus the number of agents (O(N^2)) that was clearly observable in `HierarchicalAllocations_BENCHMARK_Test.PersistentVolumes`. In addition, the role tree code was violating the convention that `Resources` belonging to different agents should never be added. This patch implements per-agent tracking of `Resources` in the roles tree, thus improving the performance of allocation (and getting rid of the potentially problematic O(N^2) asymptotic) in the case of many agents with a limited number of unique resources each. Diffs ----- src/master/allocator/mesos/hierarchical.hpp 6454cdaa19f776365df34ecf83114f0d6fa20f27 src/master/allocator/mesos/hierarchical.cpp 5fe9ffcb518b8427d663ddae43e550795d290e3c Diff: https://reviews.apache.org/r/72508/diff/1/ Testing ------- Thanks, Andrei Sekretenko
