----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72509/#review220744 -----------------------------------------------------------
Patch looks great! Reviews applied: [72508, 72509] Passed command: export OS='ubuntu:16.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/jenkins/buildbot.sh - Mesos Reviewbot On May 13, 2020, 7:43 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72509/ > ----------------------------------------------------------- > > (Updated May 13, 2020, 7:43 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-10128 > https://issues.apache.org/jira/browse/MESOS-10128 > > > Repository: mesos > > > Description > ------- > > Got rid of tracking reserved offered/allocated in roles tree. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 6454cdaa19f776365df34ecf83114f0d6fa20f27 > src/master/allocator/mesos/hierarchical.cpp > 5fe9ffcb518b8427d663ddae43e550795d290e3c > > > Diff: https://reviews.apache.org/r/72509/diff/1/ > > > Testing > ------- > > `make check` > `MESOS_BENCHMARK=1 src/mesos-tests > --gtest_filter='*HierarchicalAllocations_BENCHMARK_Test.PersistentVolumes*'` > (will run other benchmarks and attach results that have significantly > changed). > > > Thanks, > > Andrei Sekretenko > >
