> On May 12, 2020, 4:35 a.m., Greg Mann wrote: > > 3rdparty/CMakeLists.txt > > Lines 451 (patched) > > <https://reviews.apache.org/r/72492/diff/1/?file=2231371#file2231371line451> > > > > Why does this need to be optional?
You are right; it doesn't. Changed to `if(WIN32 AND BUILD_SHARED_LIBS)`. > On May 12, 2020, 4:35 a.m., Greg Mann wrote: > > 3rdparty/CMakeLists.txt > > Line 859 (original), 891-892 (patched) > > <https://reviews.apache.org/r/72492/diff/1/?file=2231371#file2231371line891> > > > > Sorry I don't understand the new comment, could you clarify? Probably this should not even be `TODO`. Removed this one and adjusted the preceding comment to explain why `curl.exe` needs to be copied at build time, despite the fact that we install it now. > On May 12, 2020, 4:35 a.m., Greg Mann wrote: > > cmake/CompilationConfigure.cmake > > Lines 389 (patched) > > <https://reviews.apache.org/r/72492/diff/1/?file=2231372#file2231372line389> > > > > Is `PLANNED_PREFIX` a good name for this? Since this seems to be the > > actual install prefix we use, should we call it something like > > `MESOS_INSTALL_PREFIX`? WDYT? Renamed MESOS_POSTINSTALL_PREFIX into MESOS_FINAL_PREFIX, made it equal to CMAKE_INSTALL_PREFIX by default, got rid of PLANNED_PREFIX variable. > On May 12, 2020, 4:35 a.m., Greg Mann wrote: > > cmake/CompilationConfigure.cmake > > Lines 596 (patched) > > <https://reviews.apache.org/r/72492/diff/1/?file=2231372#file2231372line596> > > > > Should this be documented somewhere? Added decrdiption to this option in this PR and a usage example in https://reviews.apache.org/r/72535/. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72492/#review220713 ----------------------------------------------------------- On May 20, 2020, 9:31 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72492/ > ----------------------------------------------------------- > > (Updated May 20, 2020, 9:31 p.m.) > > > Review request for mesos and Greg Mann. > > > Bugs: MESOS-6771 > https://issues.apache.org/jira/browse/MESOS-6771 > > > Repository: mesos > > > Description > ------- > > Introduced install target into cmake build. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt 7b84f12b678319df3847cffbf025324dfa09f171 > cmake/CompilationConfigure.cmake af1a8b57079ceb00b0fcfc218f8989117b69aef2 > src/CMakeLists.txt 810acbf0d92df7bc095d8fd5c40c2c4dce8cff34 > src/checks/CMakeLists.txt a3a6aed18429979cd43b9d8a7be9753f4bd3feba > src/cli/CMakeLists.txt e99b055ebb0fc0a97955bcb71c74bd9a8c6923ed > src/java/CMakeLists.txt 81eb9b56ac91b1e84f5f47f40c5a271bf6842ec0 > src/launcher/CMakeLists.txt 73587f4d1d0897fc0ca7e46955b67bca094696bc > src/local/CMakeLists.txt 7be3ede92392320c88d9d6ffde893a876e6dc2c6 > src/log/CMakeLists.txt 1c944706792c49fdd6f0304e08e8171a26949b11 > src/master/CMakeLists.txt f4b15b590f8065ac6ce374da09bd650250a5281f > src/resource_provider/storage/CMakeLists.txt > 90fdd61f063e32c4d412fb610fa9a0d69264f3e0 > src/slave/CMakeLists.txt f42a4a6bda7ebb0af05df051bd5f07fbef33bf6d > src/slave/container_loggers/CMakeLists.txt > b4f79a4da156808e81b44bc109d760ccb6091b12 > src/slave/containerizer/mesos/CMakeLists.txt > 92f4a49fdab43bb6767021e0332e2eaa205b0fec > src/slave/qos_controllers/CMakeLists.txt > ff9cc154c2f28235ab4fa46af761501de48a43c0 > src/slave/resource_estimators/CMakeLists.txt > 6f32421ab33ee8a25b30614594177f795da391ae > src/usage/CMakeLists.txt e51fe1e497d0f0565f9318514492ffce86e908a0 > > > Diff: https://reviews.apache.org/r/72492/diff/2/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
