----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72547/#review220889 -----------------------------------------------------------
src/Makefile.am Lines 259 (patched) <https://reviews.apache.org/r/72547/#comment309602> What goes wrong if we were to use GRPC_CPP_PLUGIN and PROTOC rather than the extra level of indirection with GRPC_CPP_PLUGIN_TARGET / PROTOC_TARGET? Seems like it would work as a dependency below, is that not the case? - Benjamin Mahler On May 27, 2020, 3:12 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72547/ > ----------------------------------------------------------- > > (Updated May 27, 2020, 3:12 p.m.) > > > Review request for mesos, Andrei Budnik, Benjamin Mahler, Greg Mann, Qian > Zhang, and Vinod Kone. > > > Bugs: MESOS-10135 > https://issues.apache.org/jira/browse/MESOS-10135 > > > Repository: mesos > > > Description > ------- > > This patch adds dependencies onto `protoc` and the GRPC C++ plugin > to the `*pb.h` / `*.pb.cc` targets. > > > Diffs > ----- > > src/Makefile.am 0b18f958bd5fb17ebada76c9445ca2768ab1ef5c > > > Diff: https://reviews.apache.org/r/72547/diff/3/ > > > Testing > ------- > > Built in internal CI on several different platforms. > > > Thanks, > > Andrei Sekretenko > >
