> On June 19, 2020, 6:28 p.m., Benjamin Mahler wrote: > > Can you mark down this breaking change in the changelog? > > > > I think we'll need to send an email to users about this change, since it > > may break some users. > > Dong Zhu wrote: > You mean this file https://github.com/apache/mesos/blob/master/CHANGELOG > ? And which section should it be added to ?
Yes, you'll need to start the 1.11.0 section, how about adding it under 'Additional API Changes' and mark it as a "breaking change" (look for past examples). - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72600/#review221037 ----------------------------------------------------------- On June 24, 2020, 9:39 a.m., Dong Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72600/ > ----------------------------------------------------------- > > (Updated June 24, 2020, 9:39 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Since text format for credential is no longer supported, remove it. > > > Diffs > ----- > > src/credentials/credentials.hpp 6e9f4aabfa810a4569acdcbeb9491f928e29bb9d > > > Diff: https://reviews.apache.org/r/72600/diff/2/ > > > Testing > ------- > > Manually tested > make check > > > Thanks, > > Dong Zhu > >
