-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72661/#review221241
-----------------------------------------------------------




include/mesos/mesos.proto
Line 1106 (original), 1106 (patched)
<https://reviews.apache.org/r/72661/#comment310088>

    I'm not sure that we should mark this as deprecated, since it's still 
useful for the LVM driver?



include/mesos/mesos.proto
Lines 1126-1129 (patched)
<https://reviews.apache.org/r/72661/#comment310090>

    Should we define this next to `CSIPluginContainerInfo` for consistency? 
Also, can we move the `Service` message up to the top level of the namespace 
without breaking the API? Would be nice for `Service` to sit higher now that 
it's used by two messages; but the name might be too generic for the top 
level...


- Greg Mann


On July 16, 2020, 1:47 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72661/
> -----------------------------------------------------------
> 
> (Updated July 16, 2020, 1:47 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Greg Mann.
> 
> 
> Bugs: MESOS-10148
>     https://issues.apache.org/jira/browse/MESOS-10148
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated `CSIPluginInfo` for supporting 3rd party CSI plugins.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5f795f5dbebc5d79791a011a47d21859ac6cb129 
>   include/mesos/v1/mesos.proto 07d2f4012551fbb941f5b3caad6caecbafbccfb5 
> 
> 
> Diff: https://reviews.apache.org/r/72661/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Reply via email to