----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72726/#review221461 -----------------------------------------------------------
Ship it! Ship It! - Qian Zhang On Aug. 4, 2020, 3:05 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72726/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2020, 3:05 a.m.) > > > Review request for mesos, Andrei Budnik and Qian Zhang. > > > Bugs: MESOS-10163 > https://issues.apache.org/jira/browse/MESOS-10163 > > > Repository: mesos > > > Description > ------- > > Previously, the volume managers would assume that they could > make CONTROLLER_SERVICE calls during plugin initialization, > regardless of whether or not the plugin provides that service. > > > Diffs > ----- > > src/csi/v0_volume_manager.cpp 89a6da5ffbcc30040a1ec33ffc2895e8bdec3423 > src/csi/v1_volume_manager.cpp 5178b2fd2cb2919fdf6fb3d073ac1f83ac934f56 > > > Diff: https://reviews.apache.org/r/72726/diff/2/ > > > Testing > ------- > > This change is necessary for a subsequent test later in this chain to pass. > > > Thanks, > > Greg Mann > >