> On Aug. 6, 2020, 9:27 a.m., Greg Mann wrote: > > src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp > > Lines 115-117 (patched) > > <https://reviews.apache.org/r/72733/diff/1/?file=2236985#file2236985line115> > > > > This seems pretty simple, could we do it now? > > Qian Zhang wrote: > Actually we have this issue in the other two isolators: > > https://github.com/apache/mesos/blob/1.10.0/src/slave/containerizer/mesos/isolators/volume/image.cpp#L118:L123 > > https://github.com/apache/mesos/blob/1.10.0/src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp#L364:L367 > > I think I can create a separate ticket for this issue and refactor all of > them later, HDYT? > > Greg Mann wrote: > Personally I think it's OK to write this isolator the "correct" way now, > we can always update the others later. I don't feel a need to keep our > isolator implementations super consistent across isolators.
Sure, let me do it for this isolator now. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72733/#review221469 ----------------------------------------------------------- On Aug. 6, 2020, 5:23 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72733/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2020, 5:23 p.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10153 > https://issues.apache.org/jira/browse/MESOS-10153 > > > Repository: mesos > > > Description > ------- > > Implemented the `prepare` method of `volume/csi` isolator. > > > Diffs > ----- > > src/CMakeLists.txt 4e15e3d99aa2cce2403fe07e762fef2fb4a27dea > src/Makefile.am 447db323875e4cad46000977f4a61600baff8f89 > src/common/validation.cpp 14a8c7b9d70c303b527e5e43012999471ced2d78 > src/slave/containerizer/mesos/isolators/volume/csi/isolator.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/volume/csi/state.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/volume/csi/state.proto PRE-CREATION > > > Diff: https://reviews.apache.org/r/72733/diff/2/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
