----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72774/#review221627 -----------------------------------------------------------
Ship it! src/master/allocator/mesos/hierarchical.cpp Line 729 (original), 731-732 (patched) <https://reviews.apache.org/r/72774/#comment310695> To make this a bit clearer, maybe start with saying that we don't use std::insert here because XXX? src/master/allocator/mesos/hierarchical.cpp Lines 2164 (patched) <https://reviews.apache.org/r/72774/#comment310697> Period at the end :P src/master/allocator/mesos/hierarchical.cpp Lines 2400 (patched) <https://reviews.apache.org/r/72774/#comment310696> Period at the end :P - Benjamin Mahler On Aug. 14, 2020, 4:56 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72774/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2020, 4:56 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-10171 > https://issues.apache.org/jira/browse/MESOS-10171 > > > Repository: mesos > > > Description > ------- > > Wired up the `OfferConstraintsFilter` into the hierarchical allocator. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > e444e470eb085cea167f84f8540d1769d662c222 > src/master/allocator/mesos/hierarchical.cpp > 9e5079942263132d09c6bd9abbdc8858cd2ef138 > > > Diff: https://reviews.apache.org/r/72774/diff/2/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
