----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72744/#review221643 -----------------------------------------------------------
Ship it! src/tests/master/update_framework_tests.cpp Lines 755 (patched) <https://reviews.apache.org/r/72744/#comment310713> Maybe this is more consistent? ``` EXPECT_CALL(*scheduler, connected(_)) .WillOnce(Invoke([](Mesos* mesos) { XXX })); ``` src/tests/master/update_framework_tests.cpp Lines 761-770 (patched) <https://reviews.apache.org/r/72744/#comment310714> Per comment on previous review, could consider using json for this? (ditto below) src/tests/master/update_framework_tests.cpp Lines 789-798 (patched) <https://reviews.apache.org/r/72744/#comment310715> Hm.. I would have guessed this reads from the /frameworks endpoint (or v1 GET_FRAMEWORKS call) to check the state change. Testing that it gets propagated to the allocator also make sense though. Perhaps we should check both? - Benjamin Mahler On Aug. 14, 2020, 4:59 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72744/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2020, 4:59 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-10171 > https://issues.apache.org/jira/browse/MESOS-10171 > > > Repository: mesos > > > Description > ------- > > Added a scheduler API test for a valid offer constraints update. > > > Diffs > ----- > > src/tests/master/update_framework_tests.cpp > 514647dd2fbd4b901b5f57a81fded949af12432a > > > Diff: https://reviews.apache.org/r/72744/diff/2/ > > > Testing > ------- > > > Thanks, > > Andrei Sekretenko > >
