----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72789/#review221678 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp Line 201 (original), 201 (patched) <https://reviews.apache.org/r/72789/#comment310739> Can we do `state::read<CSIVolumes>(volumesPath)` here so that we don't need to do any extra JSON/protobuf parsing? Then I think this change may not be necessary? - Greg Mann On Aug. 20, 2020, 9:16 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72789/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2020, 9:16 a.m.) > > > Review request for mesos, Andrei Budnik and Greg Mann. > > > Bugs: MESOS-10153 > https://issues.apache.org/jira/browse/MESOS-10153 > > > Repository: mesos > > > Description > ------- > > Checkpointed CSI volume state in stringified JSON. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/volume/csi/isolator.cpp > 535974bc9ef4049551d7ea7b464bd000deccd7e8 > > > Diff: https://reviews.apache.org/r/72789/diff/1/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
