----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72887/#review221895 -----------------------------------------------------------
src/master/allocator/mesos/hierarchical.hpp Line 971 (original), 971 (patched) <https://reviews.apache.org/r/72887/#comment310952> Let's just go with s/hierarchical_allocator/allocator// Note that this means we can only have 1 allocator process in memory, so we wouldn't be able to have a test with more than 1. I think that's currently the case with the master process too, so it's probably acceptable. As an alternative, we could do: ``` : ProcessBase(stripTrailing("(1)", process::ID::generate("allocator"))), ``` To make it "allocator", "allocator(2)", "allocator(3)", ... - Benjamin Mahler On Sept. 18, 2020, 4:54 p.m., Andrei Sekretenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72887/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2020, 4:54 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-10177 > https://issues.apache.org/jira/browse/MESOS-10177 > > > Repository: mesos > > > Description > ------- > > This allows the user to specify a fixed URL like > `https://localhost:5050/hierarchical_allocator/offer_constraints_debug` > when querying allocator HTTP endpoints instead of looking up > the allocator UPID and using that to compose an URL (like > `https://localhost:5050/hierarchical_allocator(0)/...`) > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 7e1980ef74bb4138b83707de7698f1993cc21e41 > > > Diff: https://reviews.apache.org/r/72887/diff/1/ > > > Testing > ------- > > `make check` on several platforms + tested the debug endpoint manually > > > Thanks, > > Andrei Sekretenko > >
