cf-natali opened a new pull request #392:
URL: https://github.com/apache/mesos/pull/392
In order to fix a compilation warning under recent gcc versions.
It also contains a patch which we used to maintain ourselves.
Note that since version 1.3.1 hasn't been released - picojson doesn't
seem actively maintained - this is really just the current master, and
I'm including the short commit hash in the version to indicate exactly
which version we're using.
Compilation warning:
```
../3rdparty/picojson-1.3.0/picojson.h: In member function ‘const T&
picojson::value::get() const [with T = double]’:
../3rdparty/picojson-1.3.0/picojson.h:304:124: warning: suggest parentheses
around assignment used as truth value [-Wparentheses]
304 | GET(double, (type_ == int64_type &&
(const_cast<value*>(this)->type_ = number_type,
const_cast<value*>(this)->u_.number_ = u_.int64_), u_.number_))
|
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
../3rdparty/picojson-1.3.0/picojson.h:292:12: note: in definition of macro
‘GET’
292 | return var; \
```
Fix for the compilation warning:
https://github.com/kazuho/picojson/commit/c8853367b0ad6ff6e76188e639a8e7f0706d4431
The patch we used to maintain ourselves:
https://github.com/apache/mesos/blob/master/3rdparty/picojson-1.3.0.patch
Upstream commit corresponding to this patch:
https://github.com/kazuho/picojson/commit/2f9d3cf33808615376493469c4be6942fc3c987a
And follow-up commit:
https://github.com/kazuho/picojson/commit/35ce0b6b03e0b60541258f5ad061003a696d9a34
@asekretenko @qianzhangxa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
