cf-natali commented on a change in pull request #394:
URL: https://github.com/apache/mesos/pull/394#discussion_r657452395
##########
File path: src/linux/ldcache.cpp
##########
@@ -224,7 +224,7 @@ Try<vector<Entry>> parse(const string& path)
// contained in the string table. At this point, 'data' should
// point to an address just beyond the end of the file.
Review comment:
I think the comment is stale, since `data` won't necessarily point just
beyond the end of the file anymore.
Similarly, the comment below will also be stale:
https://github.com/apache/mesos/blob/15c493c4dba2bf7b5db514e1daefc9c8d4f11bf6/src/linux/ldcache.cpp#L231
```
// Make sure the very last character in the buffer is a '\0'.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
