cf-natali commented on a change in pull request #405:
URL: https://github.com/apache/mesos/pull/405#discussion_r701417067
##########
File path: src/python/cli_new/lib/cli/http.py
##########
@@ -64,7 +65,7 @@ def read_endpoint(addr, endpoint, config, query=None):
.format(url=url, error=str(exception)))
-def get_json(addr, endpoint, config, condition=None, query=None):
+def get_json(addr, endpoint, config, query=None):
Review comment:
Are you sure that nothing uses `condition`?
Also, if you remove t, please remove the mention in the docstring as well:
```
subject to the condition specified in 'condition'. If we are
```
##########
File path: src/python/cli_new/lib/cli/http.py
##########
@@ -37,6 +37,7 @@ def read_endpoint(addr, endpoint, config, query=None):
try:
addr = cli.util.sanitize_address(addr)
+
Review comment:
Nit: why the newline?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
