qianzhangxa commented on code in PR #422:
URL: https://github.com/apache/mesos/pull/422#discussion_r878955437
##########
support/packaging/centos/build-docker-centos.sh:
##########
@@ -24,7 +24,7 @@
DOCKER_CONTEXT_DIR="${SOURCE_DIR}/centos${CENTOS_DISTRO}/rpmbuild/RPMS/x86_64"
cat <<EOF > "${DOCKER_CONTEXT_DIR}/Dockerfile"
FROM centos:${CENTOS_DISTRO}
-ADD mesos-?.?.?-*.rpm /
Review Comment:
A single `*` seems too wide to me, can we have a pattern to still enforce
the format of [semantic versioning](https://semver.org/)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
