qianzhangxa commented on code in PR #446: URL: https://github.com/apache/mesos/pull/446#discussion_r962313764
########## src/slave/containerizer/mesos/isolators/cgroups/subsystems/blkio.cpp: ########## @@ -107,226 +107,205 @@ Future<ResourceStatistics> BlkioSubsystemProcess::usage( CgroupInfo::Blkio::CFQ::Statistics totalCfqRecursive; CgroupInfo::Blkio::Throttling::Statistics totalThrottling; - // Get CFQ statistics. + // CFQ was removed from kernel 5.x, so be ready to handle missing statistics. + Try<vector<cgroups::blkio::Value>> time = cfq::time(hierarchy, cgroup); Review Comment: Is there a way to detect whether CFQ is support or not? If it is not supported, then maybe we can skip calling the following `cfq::` methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
