DevinLeamy commented on code in PR #477: URL: https://github.com/apache/mesos/pull/477#discussion_r1462302777
########## src/slave/containerizer/mesos/isolators/network/port_mapping.cpp: ########## @@ -1689,13 +1684,54 @@ class RatesCollectorProcess : public Process<RatesCollectorProcess> } private: - void schedule() + // This method is mostly a copy of routing::link::statistics(), but + // with the ability to use the existing links cache. It was copied + // here to preserve libnl-agnostic interface of routing package and + // ease the cleanup when this collector will be replaced with eBPF. + static hashmap<string, uint64_t> statistics( + const Netlink<struct nl_cache>& cache, + const string& link) Review Comment: This can be removed in favor of using `this->link` directly. Any reason not to? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@mesos.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
