----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74919/#review226275 -----------------------------------------------------------
support/post-reviews.py Lines 357 (patched) <https://reviews.apache.org/r/74919/#comment314520> For some reason the string "--update-all" when converted into bytes yields b'\xe2\x80\x94-update-all' rather than b"--update-all". As a result, comparison with "--update-all" didn't work (as you'd expect) and I, thus, couldn't do what I initially wanted which was: `[arg for arg in sys.argv[1:] if not arg in ['--update-all']]` If you understand why this doesn't work, let me know! - Devin Leamy On Feb. 29, 2024, 11:14 p.m., Devin Leamy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74919/ > ----------------------------------------------------------- > > (Updated Feb. 29, 2024, 11:14 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Adds a flag `--update-all` that will automatically update all diffs, > without prompting the user. If the flag is not provided the user will > be prompted for every diff, like usual. > > > Diffs > ----- > > support/post-reviews.py 799f20d898f42262cd6eba8b603020b151fbe9e9 > > > Diff: https://reviews.apache.org/r/74919/diff/1/ > > > Testing > ------- > > > Thanks, > > Devin Leamy > >
