DevinLeamy commented on PR #514: URL: https://github.com/apache/mesos/pull/514#issuecomment-1994638508
> we don't enforce all of these rules, but I'll get this landed with most of the changes: > > * Two free lines between functions: I think this rule was primarily for .cpp files, but this is ok in hpp files too, we're probably inconsistent in the header files, for example I see that cgroups.hpp groups some related things with a single line, and then uses two lines in other places, it's pretty inconsistent. > * One free line between ending namespaces: is this a clang format rule? I'm fine with enforcing this, but I imagine we're not consistent about it. > * One free line between methods: not a hard rule, typically used for one liners, e.g. https://github.com/apache/mesos/blob/1.11.0/3rdparty/stout/include/stout/option.hpp#L116-L117 > * Ending namespace having format } // namespace {.: looks good I based most of this on what I saw being done in `cgroups.hpp` and `cgroups.cpp`, which I think you might've noticed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
