DevinLeamy commented on code in PR #523:
URL: https://github.com/apache/mesos/pull/523#discussion_r1530967376
##########
src/linux/cgroups2.cpp:
##########
@@ -265,7 +265,7 @@ Try<Nothing> destroy(const string& cgroup)
return Error("There does not exist a cgroup at '" + absolutePath + "'");
}
- Try<Nothing> rmdir = os::rmdir(absolutePath);
+ Try<Nothing> rmdir = os::rmdir(absolutePath, false);
Review Comment:
This PR has two commits. This change (and only this change) is from the
first commit, where I explain why this was introduced. TLDR: make `os::rmdir`
use `rmdir` instead of `rm`.
##########
src/linux/cgroups2.cpp:
##########
@@ -265,7 +265,7 @@ Try<Nothing> destroy(const string& cgroup)
return Error("There does not exist a cgroup at '" + absolutePath + "'");
}
- Try<Nothing> rmdir = os::rmdir(absolutePath);
+ Try<Nothing> rmdir = os::rmdir(absolutePath, false);
Review Comment:
This PR has two commits. This change (and only this change) is from the
first commit, where I explain why this was introduced. TLDR: makes `os::rmdir`
use `rmdir` instead of `rm`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
