bmahler commented on code in PR #528:
URL: https://github.com/apache/mesos/pull/528#discussion_r1532410807
##########
src/tests/containerizer/cgroups2_tests.cpp:
##########
@@ -33,7 +33,29 @@ namespace mesos {
namespace internal {
namespace tests {
-class Cgroups2Test : public TemporaryDirectoryTest {};
+const string TEST_CGROUP = "test";
+
+// Cgroups2 test fixture that ensures `TEST_CGROUP` does not
+// exist before and after the test is run.
+class Cgroups2Test : public TemporaryDirectoryTest
+{
+public:
+ static void SetUpTestCase()
Review Comment:
this looks like it should be `void SetUp() override` and below `void
TearDown() override`, which will run at the start and end of each test, as is,
these statics only run at the start and end of the fixture
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
