DevinLeamy commented on code in PR #532:
URL: https://github.com/apache/mesos/pull/532#discussion_r1535998268


##########
src/linux/cgroups2.hpp:
##########
@@ -76,6 +76,15 @@ Try<Nothing> move_process(const std::string& cgroup, pid_t 
pid);
 Try<std::string> cgroup(pid_t pid);
 
 
+// Get the processes inside of a cgroup.
+Try<std::set<pid_t>> processes(const std::string& cgroup);
+
+
+// Assign a process to a cgroup, by PID. This removes the process from its
+// current cgroup.
+Try<Nothing> assign(const std::string& cgroup, pid_t pid);

Review Comment:
   Did not mean to have two. `assign` is the name used by the initial cgroups 
so I think that's the name we should use. I've opted to replace `move_process` 
with assign. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to