DevinLeamy commented on code in PR #537:
URL: https://github.com/apache/mesos/pull/537#discussion_r1541270546
##########
src/slave/containerizer/mesos/paths.cpp:
##########
@@ -654,6 +654,30 @@ Option<ContainerID> parseCgroupPath(
return current;
}
+namespace cgroups2 {
+
Review Comment:
Could have additionally added:
```cpp
// Path to the top-level Mesos cgroup. All global resource constraints
// are impose from this cgroup.
std::string root(const std::string& root)
{
return root;
}
```
But given that it takes the flag called `cgroups_root` and simply just
returns its parameter I didn't see much of a point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
