bmahler commented on code in PR #538: URL: https://github.com/apache/mesos/pull/538#discussion_r1541949691
########## src/tests/containerizer/cgroups2_tests.cpp: ########## @@ -97,6 +111,92 @@ class Cgroups2Test : public TemporaryDirectoryTest }; +// Combination of a path and access flags. +typedef pair<string, int> Access; + + +Try<Nothing> deviceControllerAccesses( + const string& cgroup, + const vector<devices::Entry>& allow, + const vector<devices::Entry>& deny, + const vector<Access>& allowedAccesses, + const vector<Access>& blockedAccesses) Review Comment: Let's use a parameterized test instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
