bmahler commented on code in PR #551:
URL: https://github.com/apache/mesos/pull/551#discussion_r1554329348
##########
src/slave/containerizer/mesos/paths.hpp:
##########
@@ -320,6 +320,17 @@ std::string container(
const ContainerID& containerId,
bool leaf = false);
+
+// Get a containerId from a container's cgroup.
+// Inverse of `cgroups2::container(root, id)`.
+//
+// The provided cgroup can be an absolute path or a relative path.
+// Leaf paths (which end in `/leaf`) and non-leaf paths will resolve to the
+// same container id.
Review Comment:
to be consistent with our other "cgroup" arguments and variables in the
cgroups2 library, let's only support the relative path format here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@mesos.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
