bmahler commented on code in PR #558:
URL: https://github.com/apache/mesos/pull/558#discussion_r1567700962
##########
src/master/master.cpp:
##########
@@ -7746,6 +7746,22 @@ void Master::updateSlave(UpdateSlaveMessage&& message)
// providers as well.
}
+ // We don't expect the agent's resource version to change, but above we
+ // do have a check to see if it's changed and therefore set `updated`
+ // to true, so we might as well assign the new value here rather than
+ // ignore it.
+ //
+ // Now that we have resource versions in the agent, the lack of the
+ // update to the version here was causing MESOS-7187 to be triggered
+ // when the master receives a re-registration message from the old run
+ // of an agent and then ignores the new re-registration message from a
+ // new run of the agent. When the new agent sends the update message,
+ // the master was seeing the difference resource uuid and setting
Review Comment:
"different" thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
