bmahler commented on code in PR #565:
URL: https://github.com/apache/mesos/pull/565#discussion_r1573038742
##########
src/slave/flags.cpp:
##########
@@ -652,8 +657,25 @@ mesos::internal::slave::Flags::Flags()
add(&Flags::cgroups_limit_swap,
"cgroups_limit_swap",
"Cgroups feature flag to enable memory limits on both memory and\n"
- "swap instead of just memory.\n",
- false);
+ "swap instead of just memory. Not supported if cgroups v2 is used.\n",
+ false,
+ [](const bool& limit_swap) -> Option<Error> {
+#ifdef ENABLE_CGROUPS_V2
+ Try<bool> mounted = cgroups2::mounted();
+ if (mounted.isError()) {
+ return Error("Failed to check if cgroup2 filesystem is mounted: "
Review Comment:
nit: 2 space indent here and below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
