----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74979/#review226435 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/cgroups2/controllers/memory.cpp Lines 281-299 (patched) <https://reviews.apache.org/r/74979/#comment314633> I suspect we should just remove the stats from the message since we're reacting post-OOM, and the oom killer may have already killed processes. This makes the stats unreliable and users need to rely instead on the historical container usage metrics to better understand where the memory consumption was occurring. src/slave/containerizer/mesos/isolators/cgroups2/controllers/memory.cpp Lines 286 (patched) <https://reviews.apache.org/r/74979/#comment314634> we should't return here, since we still want to report that the limitation was reached, similar to how our v1 isolation logic proceeds despite errors src/slave/containerizer/mesos/isolators/cgroups2/controllers/memory.cpp Lines 306 (patched) <https://reviews.apache.org/r/74979/#comment314635> ditto here src/slave/containerizer/mesos/isolators/cgroups2/controllers/memory.cpp Lines 311 (patched) <https://reviews.apache.org/r/74979/#comment314636> ditto here src/slave/containerizer/mesos/isolators/cgroups2/controllers/memory.cpp Lines 324-325 (patched) <https://reviews.apache.org/r/74979/#comment314637> ditto here, need to handle missing hard limit - Benjamin Mahler On May 10, 2024, 10:21 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74979/ > ----------------------------------------------------------- > > (Updated May 10, 2024, 10:21 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Introduces OOM listening to the MemoryControllerProcess so that we > detect, report, and respond to OOM events. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/cgroups2/controllers/memory.hpp > 2e60b2c19a781c2d8ab24e89e440383ca517868c > src/slave/containerizer/mesos/isolators/cgroups2/controllers/memory.cpp > 732b1c65febdc78d8854e571bb02a9d367528434 > > > Diff: https://reviews.apache.org/r/74979/diff/1/ > > > Testing > ------- > > > Thanks, > > Jason Zhou > >
