> On May 13, 2024, 8:04 p.m., Benjamin Mahler wrote: > > src/slave/containerizer/mesos/isolators/cgroups2/controllers/memory.cpp > > Lines 196 (patched) > > <https://reviews.apache.org/r/74985/diff/1/?file=2287761#file2287761line196> > > > > maybe a TODO here to report more stats, since there appears to be lots > > more available in the stat file?
Done > On May 13, 2024, 8:04 p.m., Benjamin Mahler wrote: > > src/slave/containerizer/mesos/isolators/cgroups2/controllers/memory.cpp > > Lines 198-202 (patched) > > <https://reviews.apache.org/r/74985/diff/1/?file=2287761#file2287761line198> > > > > why is this user? this looks like total memory consumption of the > > container? Done, user was renamed to Current to reflect the current memory usage > On May 13, 2024, 8:04 p.m., Benjamin Mahler wrote: > > src/slave/containerizer/mesos/isolators/cgroups2/controllers/memory.cpp > > Lines 229-236 (patched) > > <https://reviews.apache.org/r/74985/diff/1/?file=2287761#file2287761line229> > > > > Looks like this should be coming from memory.stat's unevictable stat > > instead? Done, set_mem_unevictable_bytes now takes in memoryStats->unevictable.bytes(). Field is confirmed to exist by checking memory.stat file on a cgroups2-enabled machine. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74985/#review226436 ----------------------------------------------------------- On May 13, 2024, 10:47 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74985/ > ----------------------------------------------------------- > > (Updated May 13, 2024, 10:47 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Introduces `::usage` to the MemoryControllerProcess to report the total > memory usage of a cgroup as well as memory usage statistics provided > by `cgroups2::memory:stats`. > > > Diffs > ----- > > include/mesos/mesos.proto 2aad66d676a3fcfa5299581a1c316309da7cf4f3 > include/mesos/v1/mesos.proto d4ab6f35fdabe9673a480f0716dc5d589c645e26 > src/linux/cgroups2.hpp 619c75737a3836839b2eb63924a3ac51f8baf75e > src/slave/containerizer/mesos/isolators/cgroups2/controllers/memory.hpp > 2e60b2c19a781c2d8ab24e89e440383ca517868c > src/slave/containerizer/mesos/isolators/cgroups2/controllers/memory.cpp > 732b1c65febdc78d8854e571bb02a9d367528434 > src/tests/containerizer/memory_isolator_tests.cpp > ec0f359a253ebaf8d7937876ba6f265d93d45ddd > src/tests/mesos.cpp 762200cda73e3e1cda0755c44f4fffc974f0927b > > > Diff: https://reviews.apache.org/r/74985/diff/2/ > > > Testing > ------- > > > Thanks, > > Jason Zhou > >
