----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74989/#review226456 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Mahler On May 14, 2024, 9:58 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74989/ > ----------------------------------------------------------- > > (Updated May 14, 2024, 9:58 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > The change involves migrating the isolator tests from > MesosTests to ContainerizerTest which inherit from MesosTests > This allows cgroups2 tests to create cgroups in appropriate > directories during tests. > > > Diffs > ----- > > src/tests/containerizer/cpu_isolator_tests.cpp > 9498a23daed75ffd65f10381389e882a5bc4a2ed > src/tests/containerizer/memory_isolator_tests.cpp > ec0f359a253ebaf8d7937876ba6f265d93d45ddd > > > Diff: https://reviews.apache.org/r/74989/diff/1/ > > > Testing > ------- > > Tested the CPU Isolator and Memory Isolator tests. > CPU passes on CentOS 9 with Cgroups2 enabled, and passes on CentOS 7 with > Cgroups1 > Memory passes on CentOS 7. Fix for tests in CentOS 9 is in > https://reviews.apache.org/r/74985/ > > > Thanks, > > Jason Zhou > >
