----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74981/#review226462 -----------------------------------------------------------
Ship it! just some minor nits below src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp Line 220 (original), 220 (patched) <https://reviews.apache.org/r/74981/#comment314666> this should continue working as is (see below) src/slave/main.cpp Lines 279 (patched) <https://reviews.apache.org/r/74981/#comment314663> nit: wrap lines at 80 src/tests/containerizer/cgroups2_tests.cpp Line 259 (original), 259 (patched) <https://reviews.apache.org/r/74981/#comment314665> this should still work without needing a change due to the implicit initializer list constructor (same as vector) src/tests/mesos.cpp Line 810 (original), 810 (patched) <https://reviews.apache.org/r/74981/#comment314664> nit: indentation is off now - Benjamin Mahler On May 17, 2024, 8:43 p.m., Jason Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74981/ > ----------------------------------------------------------- > > (Updated May 17, 2024, 8:43 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Modifies the cgroups2::controllers::enable function to take in a set of > strings for controllers. > This helps eliminate the possibility of duplicate controllers in the > argument, and brings it in line with the cgroups2::controllers::disable > function > > > Diffs > ----- > > src/linux/cgroups2.hpp 97260c0d60009162ca58c69bc97078e2b42ff1a7 > src/linux/cgroups2.cpp e9845bb56c43ca5312431fd0a7d11a5685d132d4 > src/slave/containerizer/mesos/isolators/cgroups2/cgroups2.cpp > 76c8df9b10ff8142c89a812f24acb8c6accc0ae5 > src/slave/main.cpp f4e7f3b6436f548e67416fd6f186dec425187444 > src/tests/containerizer/cgroups2_tests.cpp > e36f99b64ddd3f8801f499fbfdb4df87b0ddf3ca > src/tests/mesos.cpp ffbb30b9551b8c090c908faa693f1a92463bdfab > > > Diff: https://reviews.apache.org/r/74981/diff/1/ > > > Testing > ------- > > Cgroups2 tests passed on CentOS 9 machine with cgroups2 enabled > > > Thanks, > > Jason Zhou > >
